platform icon indicating copy to clipboard operation
platform copied to clipboard

[2023.11] [coq-lsp 0.2.0] [v8.19] Draft Windows build

Open ejgallego opened this issue 1 year ago • 13 comments

Changes:

  • Simplify some paths and logic
  • Updated for 8.19

ejgallego avatar Feb 05 '24 20:02 ejgallego

@ejgallego : anything I can help with?

MSoegtropIMC avatar Feb 09 '24 09:02 MSoegtropIMC

@ejgallego : anything I can help with?

Everything good, thanks! I started with the 8.19 pick, but indeed had to remove a few broken contribs. The installer seems to work good now, and it is simpler than in previous versions as I didn't have to patch Coq this time.

ejgallego avatar Feb 09 '24 12:02 ejgallego

Are you using the installer in a lecture?

MSoegtropIMC avatar Feb 09 '24 13:02 MSoegtropIMC

This particular artifact hasn't been tested yet, however the artifacts for 8.17 / 8.18 have been used by quite a few people with pretty good results I understand, including lectures.

ejgallego avatar Feb 09 '24 14:02 ejgallego

Artifact tested, working pretty well on the cases we have.

[Note that the current installer still requires to config VSCode as outline in the README on coq-lsp for Windows]

ejgallego avatar Feb 09 '24 16:02 ejgallego

@MSoegtropIMC , actually there is something strange going on here (and in the sister PRs for 8.18 and 8.17) , for some reason, CoqIDE is not building correctly, I am not sure why, it seems the custom repos logic is working as intended.

ejgallego avatar Sep 09 '24 17:09 ejgallego

@ejgallego : as you might remember we always had a patched lablgtk in Windows + a few matching patches in CoqIDE. Recently this was fixed up in lablgtk upstream which requires adjustments in CoqIDE. The errors I see are in this area - I would say the patch level of CoqIDE doesn't match the version of lablgtk used. Which one is wrong is hard to tell, but I guess CoqIDE patches are missing.

MSoegtropIMC avatar Sep 10 '24 07:09 MSoegtropIMC

Btw.: I made good progress with solving the path length issue permanently. The manifest changes work fine, I just need a reliable automation for the registry change (especially on GIT runners).

MSoegtropIMC avatar Sep 10 '24 07:09 MSoegtropIMC

Which one is wrong is hard to tell, but I guess CoqIDE patches are missing.

Indeed, it seems like CoqIDE patches not being applied, however the local repos seems setup correctly, bizarre.

ejgallego avatar Sep 10 '24 10:09 ejgallego

This issue is that you have "coqide.8.19.0" but an opam package with the patch exists only for coqide.8.19.2.

MSoegtropIMC avatar Sep 10 '24 12:09 MSoegtropIMC

I need to merge this upstream for all versions, but too busy with other loose ends ...

MSoegtropIMC avatar Sep 10 '24 12:09 MSoegtropIMC

This issue is that you have "coqide.8.19.0" but an opam package with the patch exists only for coqide.8.19.2.

Thanks @MSoegtropIMC , where do you see "coqide.8.19.0", I see instead:

PACKAGES="${PACKAGES} coqide.8.19.2"

I need to merge this upstream for all versions, but too busy with other loose ends ...

I will be happy to help with that, just give me a heads up when you want this to land in the main branch.

The setup is now standard, just adding coq-lsp to PACKAGES will do the trick.

Note that however it is strongly recommended to run the +lsp Coq branches, due to critical patches for UI stability.

ejgallego avatar Sep 10 '24 13:09 ejgallego

Yes, sorry - I somehow ended up browsing the initial commit where it was 8.19.0. The latest commit is indeed 8.19.2. I need to do a local test.

MSoegtropIMC avatar Sep 10 '24 13:09 MSoegtropIMC