opam icon indicating copy to clipboard operation
opam copied to clipboard

Allow dune >= 3.15.3 in all packages restricting dune to < 3.14

Open MSoegtropIMC opened this issue 1 year ago • 7 comments

MSoegtropIMC avatar Jul 03 '24 15:07 MSoegtropIMC

Unfortunately, Dune >= 3.14 (which includes 3.15.3) is incompatible with the way our continuous integration is setup, as you can see from the failures. (My hypothesis is that dune subst does not support the fact that the home directory contains an opam component.)

Polluting the opam files of coq-core with the upper bound on dune is certainly crude, but it gets the continuous integration running. It would be better to somehow enforce the upper bound in scripts/opam-coq-setup-root, for instance. But nobody investigated how to do that properly.

silene avatar Jul 04 '24 02:07 silene

Doesn't seem to work

SkySkimmer avatar Jul 04 '24 08:07 SkySkimmer

The issue is that there are some coq opam packages which do require dune >= 3.14. Also in Coq Platform I had to upgrade to dune 3.15.3 cause of issues.

IMHO it should be discussed with the dune team if the way the CI is setup will permanently be incompatible with dune - in this case the only way is to change the CI setup - or if dune will be made compatible in the near future.

MSoegtropIMC avatar Jul 04 '24 08:07 MSoegtropIMC

For a few months I can use patched opam files in Coq Platform for the coq packages, but not forever.

MSoegtropIMC avatar Jul 04 '24 08:07 MSoegtropIMC

cc @rgrinberg

SkySkimmer avatar Jul 04 '24 08:07 SkySkimmer

FYI @rgrinberg, the issue at stake would be: https://github.com/ocaml/dune/pull/9895#issuecomment-2090421992

erikmd avatar Jul 05 '24 20:07 erikmd

Not sure I really understand the issue, but you might be able to fix if you disable substitution altogether with (subst disabled) in the dune-project file. To help out more, I will need a ticket with a more complete description of the problem.

rgrinberg avatar Jul 06 '24 21:07 rgrinberg

Closed in favour of https://github.com/coq/opam/pull/3228 - this follows the approach also used in the Coq released packages.

MSoegtropIMC avatar Dec 03 '24 14:12 MSoegtropIMC