opam icon indicating copy to clipboard operation
opam copied to clipboard

coq-simple-io.dev : remove dune upper bound

Open liyishuai opened this issue 1 year ago • 6 comments

as the Coq docker images have pinned Dune to 3.14.

liyishuai avatar Apr 08 '24 08:04 liyishuai

The upper bound was to work around a bug (discussed here) that manifests itself on opam CI with dune 3.14. So if this PR doesn't pass CI, a more local workaround may be to allow newer dunes only in downstream configs such as QuickChick CI.

Lysxia avatar Apr 08 '24 08:04 Lysxia

@erikmd is it worth downgrading the Dune version for coqorg/coq? Currently dev packages either fail the CI here or cannot be installed on the Docker images. https://github.com/coq-community/docker-base/commit/c6bff6458708bc113b03c36619718720454eafc2

liyishuai avatar Apr 23 '24 04:04 liyishuai

Hi @liyishuai ! thanks for the ping.

Sure, this is easy to do. Which version of Dune would be OK?

erikmd avatar Apr 23 '24 08:04 erikmd

Maybe 3.13.1 ?

unless the latest releases 3.15.0 / 3.15.1 would fix the issue you speak about?

https://github.com/ocaml/dune/releases

erikmd avatar Apr 23 '24 08:04 erikmd

Hi @liyishuai, the downgrade is complete, see e.g.:

Do you think you could file an issue in Dune's repo if it is not already the case?

Also Cc @ybertot FYI

erikmd avatar Apr 23 '24 10:04 erikmd

Now there's https://github.com/ocaml/dune/releases/tag/3.15.2. Maybe worth testing it on Coq CI.

liyishuai avatar Apr 23 '24 10:04 liyishuai