coq icon indicating copy to clipboard operation
coq copied to clipboard

Test-suite should enable native compilation

Open ppedrot opened this issue 7 years ago • 9 comments

Version

Coq 8.8.

Description of the problem

Contrarily to the stdkib, the test-suite is compiled with automatic native compilation disabled. This prevents systematic checking of many kernel constructions that do not appear in the stdlib.

ppedrot avatar Jun 17 '18 11:06 ppedrot

@maximedenes IIRC most tests are not run via coqc but rather coqtop... can native be triggered in this case?

gares avatar Jun 17 '18 18:06 gares

IIRC most tests are not run via coqc but rather coqtop... can native be triggered in this case?

No, indeed. IMHO the test suite should generate .vo files, also be compiled using the native compiler, and checked using coqchk. So maybe we can generalize this issue.

One step would be to stop using file names that are not valid for coqc in the test suite.

maximedenes avatar Jun 17 '18 19:06 maximedenes

One step would be to stop using file names that are not valid for coqc in the test suite.

Or to generalize what filenames are valid for coqc... Whether to do one or the other has been a long standing question if I'm not mistaken.

Zimmi48 avatar Jun 17 '18 23:06 Zimmi48

Good point, I'll open an issue so that we can discuss it.

maximedenes avatar Jun 18 '18 06:06 maximedenes

It should be fairly easy to add some coqnative calls in the test suite nowadays.

SkySkimmer avatar Sep 29 '21 15:09 SkySkimmer

@Alizter what's the status of this in your test-suite branch?

ejgallego avatar May 28 '22 16:05 ejgallego

@ejgallego native is not enabled since I don't know how to do the deps correctly. Currently the test suite pr doesn't work with any form of configure.

I have a coq native rule ready in there though, and it seems to work. But it would be good to support native enabled from the beginning.

Alizter avatar May 28 '22 17:05 Alizter

This is fixed now, right?

JasonGross avatar Aug 05 '23 22:08 JasonGross

When coq is configured with native enabled the test suite now runs with native ondemand AFAICT

SkySkimmer avatar May 06 '24 12:05 SkySkimmer