coq icon indicating copy to clipboard operation
coq copied to clipboard

[coqdep] Turn dependency resolution failure from a warning to a fatal error

Open ejgallego opened this issue 3 years ago • 43 comments

Strict mode means we fail when we cannot locate a file.

This is an experiment before implementing -modules.

Relevant OCaml issue is https://github.com/ocaml/ocaml/issues/8625

ejgallego avatar May 26 '22 19:05 ejgallego

Why did you put Error back in?

Alizter avatar May 26 '22 19:05 Alizter

The job library:ci-fiat_crypto_legacy has failed in allow failure mode ping @JasonGross

coqbot-app[bot] avatar May 26 '22 19:05 coqbot-app[bot]

Why did you put Error back in?

Not used anywhere else, dummy module.

ejgallego avatar May 26 '22 19:05 ejgallego

Related issues:

  • https://github.com/coq/coq/issues/10156
  • https://github.com/coq/coq/issues/13688
  • https://github.com/coq/coq/issues/11454

Alizter avatar May 27 '22 13:05 Alizter

The job library:ci-fiat_crypto_legacy has failed in allow failure mode ping @JasonGross

coqbot-app[bot] avatar May 31 '22 18:05 coqbot-app[bot]

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar Jul 07 '22 02:07 coqbot-app[bot]

The job library:ci-fiat_crypto_legacy has failed in allow failure mode ping @JasonGross

coqbot-app[bot] avatar Jul 07 '22 16:07 coqbot-app[bot]

The job library:ci-fiat_crypto_legacy has failed in allow failure mode ping @JasonGross

coqbot-app[bot] avatar Sep 26 '22 17:09 coqbot-app[bot]

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar May 19 '23 02:05 coqbot-app[bot]

This PR was not rebased after 30 days despite the warning, it is now closed.

coqbot-app[bot] avatar Jun 19 '23 02:06 coqbot-app[bot]