bot icon indicating copy to clipboard operation
bot copied to clipboard

coqbot should allow minimization from the checks tab

Open JasonGross opened this issue 4 years ago • 1 comments

In addition to posting comments, and perhaps even when the test-suite fails, each failure in the checks tab (example) could get a line that says something like "🚀 Click here to minimize this failure". The overall checks/pipeline tab could get something like " 🚀 Click here to minimize all suggested failures" (maybe with a list of the ones that will be minimized?) and maybe " 🚀 💥 Click here to minimize all failures, including those that are not suggested" (maybe with a list of the ones that will be minimized?) The link could be a POST (or GET?) request to coqbot. It would be nice to have #184 in place before this.

JasonGross avatar Dec 14 '21 17:12 JasonGross

There is probably some logic that can be shared between the step when a job finishes and we want to inform the user that the base job has not failed and this is a candidate for minimization, and the step when a pipleine finishes and we prepare the comment suggesting minimization. This is something that we can pair code with Jason.

Apart from this there is also some implementation to do to make it possible to just minimize by clicking on a link. Or we can include a custom further action in the result of the check run: https://docs.github.com/en/rest/reference/checks#create-a-check-run

Zimmi48 avatar Dec 27 '21 18:12 Zimmi48