bot icon indicating copy to clipboard operation
bot copied to clipboard

GitHub Checks feedback

Open Zimmi48 opened this issue 5 years ago • 3 comments

Issue to get feedback on the new GitHub Checks reports for GitLab pipelines (requires having installed using the GitHub App method).

Zimmi48 avatar Sep 21 '20 12:09 Zimmi48

Two checksuites created for the same pipeline:

See https://github.com/coq/coq/commits/14aaac29871328d6a369d52d8febd74afc727d64 / https://github.com/coq/coq/pull/13061

New occurrence: https://github.com/coq/coq/pull/12391/checks?sha=99f7cf5918b15efe4184d541a4d41d12d9140b28

Issue not seen for a long while so marked as resolved.

Zimmi48 avatar Sep 22 '20 15:09 Zimmi48

Hi @Zimmi48 , I've just tested the coqbot-app in docker-coq and the Checks tab (listing all GitLab CI jobs) is very nice! → https://github.com/coq-community/docker-coq/pull/14/checks

Some small suggestions BTW, regarding the information that could be added:

  • the total elapsed time, e.g., "in 2 minutes and 45 seconds" (or "in 2 minutes and 45 seconds (queued for 3 seconds)") − I dunno whether there's an appropriate API for that;
  • regarding the previous item, note that https://github.com/coq-community/docker-coq/pull/14/checks?check_run_id=1407648482 says "succeeded 18 hours ago in 0s" (is it a bug?);
  • and to further distinguish the view of the runs GitLab CI pipeline (branch) and GitLab CI pipeline (pull request), you might want to add (in line with the Bot merge 19855e04 and 8ffbad26 message):
    • For GitLab CI pipeline (branch) → some text such as "This is a regular pipeline for the foo branch." (maybe with a link to https://github.com/username/reponame/tree/branchname);
    • For GitLab CI pipeline (pull request) → some text such as This is a pull request pipeline for the [foo](URL) branch ([19855e04](URL)), after merging [PR #1](URL) ([8ffbad26](URL));
  • Note that this latter suggestion was inspired by the Travis CI checks: branch, pull request.

erikmd avatar Nov 17 '20 10:11 erikmd

Thanks for the feedback. Yes, so far I don't provide the "started at" and "completed at" pieces of information. I'll take your suggestions into account sometimes later this week.

Zimmi48 avatar Nov 17 '20 11:11 Zimmi48