math-classes icon indicating copy to clipboard operation
math-classes copied to clipboard

Port Coq code to use 'done' tactic instead of 'easy' and benchmark

Open ndcroos opened this issue 1 year ago • 6 comments

See https://github.com/coq-community/math-classes/issues/128 See also this discussion: https://coq.zulipchat.com/#narrow/stream/237977-Coq-users/topic/Error.20in.20MathClasses.2C.20adding.20an.20import

Todo's:

  • benchmarking
  • hide fast_done

ndcroos avatar Jul 30 '24 16:07 ndcroos

@ndcroos the fast_done and done tactics are as far as I know independent of the rest of stdpp. So why do you need to bundle base.v? This is a big file with lots of choices in how to configure Coq, that will take quite a lot of time to maintain inside this project.

palmskog avatar Jul 30 '24 16:07 palmskog

@palmskog I need base.v for not_symmetry. I still need to delete code in (mostly) base.v that is not needed.

ndcroos avatar Jul 30 '24 16:07 ndcroos

I got a lot of errors executing make that are due to easy --> done changes, so I think it is makes more sense to revert all the easy --> done changes, and then doing them again one by one, while making sure that the project compiles. I also moved stdpp_tactics.v to the misc directory.

(It seems like perhaps the most straightforward changes are those were easy is the last step in the proof. But I am not sure of this.)

ndcroos avatar Jul 31 '24 14:07 ndcroos

Files where replacing 'easy' didn't work:

  • theory/series
  • implementations/dyadics.v
  • misc/util.v (because of circular dependency)

ndcroos avatar Jul 31 '24 21:07 ndcroos

Thanks @ndcroos ! What's the status of this?

spitters avatar Aug 14 '24 08:08 spitters

@spitters I only need to do the benchmarking, using make pretty-timed, but I have not figured out yet how to execute the benchmark for the made changes. Help with this is very welcome here.

ndcroos avatar Aug 14 '24 12:08 ndcroos