coq-nix-toolbox icon indicating copy to clipboard operation
coq-nix-toolbox copied to clipboard

Generate GitHub workflows on Ubuntu and macOS.

Open Zimmi48 opened this issue 4 years ago • 14 comments

Reopening #56 from a local branch to enable pushing to Cachix.

Zimmi48 avatar Aug 11 '21 13:08 Zimmi48

@siraben: In principle, everything has been uploaded to the coq-community Cachix already, so you should be able to start taking advantage of it (without waiting for this PR to be merged).

Zimmi48 avatar Aug 11 '21 22:08 Zimmi48

@Zimmi48 I have the coq-community cachix in my Nix config, but I can't seem to avoid rebuilding coqPackages.VST.

siraben avatar Dec 28 '21 08:12 siraben

That's not surprising, since we haven't updated this PR in five months. I will take Cyril's comment into account and rebase this.

Zimmi48 avatar Dec 28 '21 09:12 Zimmi48

I have implemented the suggested change. I have kept the behavior of genNixAction unchanged (doesn't produce cross-platform workflows and doesn't change their title) and introduced a new function genCrossPlatformNixAction that generates workflows for Ubuntu and macOS with information on the platform in the workflow name.

Zimmi48 avatar Dec 28 '21 11:12 Zimmi48

Instead, we could also decide to set this in .nix/config.nix (it would probably make a lot of sense if it was set there) but I haven't really looked yet for the implementation logic that would make that possible.

Zimmi48 avatar Dec 28 '21 11:12 Zimmi48

Something else that we could decide is to restrict on which events we run the macOS workflows (e.g., to avoid delaying PR CI).

Zimmi48 avatar Dec 28 '21 11:12 Zimmi48

@CohenCyril There were three failures, all in the Cachix install step, all on the macOS platform:

  • https://github.com/coq-community/coq-nix-toolbox/runs/4649853564?check_suite_focus=true
  • https://github.com/coq-community/coq-nix-toolbox/runs/4649788595?check_suite_focus=true
  • https://github.com/coq-community/coq-nix-toolbox/runs/4649799155?check_suite_focus=true

Should we report them to Domen?

Zimmi48 avatar Dec 28 '21 16:12 Zimmi48

I encountered a similar failure recently, what if you bump the cachix action to v16?

siraben avatar Dec 28 '21 17:12 siraben

We're already using v16 for the install-nix-action, and v10 for the cachix-action, which are the latest versions AFAICT.

Zimmi48 avatar Dec 28 '21 17:12 Zimmi48

BTW, @siraben the VST jobs on macOS for Coq 8.12 and 8.13 (the only ones that exist AFAICS) have completed, so they should be available in Coq-community's Cachix.

Zimmi48 avatar Dec 28 '21 17:12 Zimmi48

@Zimmi48 Thanks, it seems to have fetched from cache now. 😊

siraben avatar Dec 29 '21 02:12 siraben

There were three failures, all in the Cachix install step, all on the macOS platform

It happened again:

  • https://github.com/coq-community/coq-nix-toolbox/runs/4666174442?check_suite_focus=true
  • https://github.com/coq-community/coq-nix-toolbox/runs/4668651196?check_suite_focus=true

cc @domenkozar

(We do not get such failures anymore in Ubuntu since the last install-nix-action update, but they still often happen on macOS apparently...)

Zimmi48 avatar Dec 30 '21 20:12 Zimmi48

https://github.com/NixOS/nix/issues/3605

domenkozar avatar Dec 31 '21 18:12 domenkozar

Using this PR to test NixOS/nixpkgs#189997 on macOS.

Zimmi48 avatar Sep 07 '22 11:09 Zimmi48