ioBroker.roborock icon indicating copy to clipboard operation
ioBroker.roborock copied to clipboard

Compatibility check and testing for Responsive Design (jsonConfig)

Open ioBroker-Bot opened this issue 1 year ago • 17 comments

Notification from ioBroker Check and Service Bot

Dear Adapter developer,

ioBroker should be fully usable and operable on mobile devices

So please check your adapter jsonConfig for Responsive Design. You can perform these tests in the developer console of your browser (F12)


For jsonConfig, all resolutions should be taken into account in the respective inputs.

The following resolutions are provided:

  • xl - width in 1/12 of screen on extra large screens (1536px < width)
  • lg - width in 1/12 of screen on large screens (1200px <= width < 1536px)
  • md - width in 1/12 of screen on middle screens (900px <= width < 1200px)
  • sm - width in 1/12 of screen on small screen (600px <= width < 900px)
  • xs - width in 1/12 of screen on tiny screens (width < 600px)

We recommend the following values for the standard layout

"xs": 12,
"sm": 12,
"md": 6,
"lg": 4,
"xl": 4

The following entry should be made below "type": "tabs" in order to display a clearly legible table bar:

"tabsStyle": {
  width: "calc(100% - 100px)"
},

Please close the issue after you checked it.

Feel free to contact me (@iobroker-bot) if you have any questions.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@simatec for evidence

Note: If you added Responsive Design tests already, simply close this issue.

ioBroker-Bot avatar Nov 26 '24 22:11 ioBroker-Bot

see https://github.com/copystring/ioBroker.roborock/issues/679#issuecomment-2500864802

mcm1957 avatar Nov 26 '24 22:11 mcm1957

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 10 '24 23:12 stale[bot]

Feel free to close as @simatec already stated the the UI looks good.

We max evaluate how to exclude the checker errors in you case. As this is currently the only adapter I know which states to have worse look when using the size attributes I'm not sure how to proceed.

You can keep the issue open too to discuss a solution for your adapter which is not closed / updated by checker bot.

mcm1957 avatar Dec 12 '24 19:12 mcm1957

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 26 '24 22:12 stale[bot]

The values for xs, sm, md, lg and xl are still missing in the jsonConfig

simatec avatar Jan 06 '25 18:01 simatec

Hello @simatec,

we have discussed this before. See issue https://github.com/copystring/ioBroker.roborock/issues/679#issuecomment-2500864802. Adding these values to the config of my adapter makes the options looks worse and I will not add the values.

copystring avatar Jan 06 '25 21:01 copystring

I have created a PR for you that does not change your design, but ensures a responsive design

Here is the PR https://github.com/copystring/ioBroker.roborock/pull/751

simatec avatar Jan 07 '25 22:01 simatec

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 21 '25 22:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 05 '25 06:02 stale[bot]

Unstale

copystring avatar Feb 05 '25 06:02 copystring

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 19 '25 11:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 05 '25 18:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 20 '25 07:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 04 '25 06:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 18 '25 18:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 04 '25 07:05 stale[bot]

This issue should not be considered stale. Please process and close it if completed.

ioBroker-Bot avatar May 04 '25 18:05 ioBroker-Bot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 18 '25 19:05 stale[bot]