v86 icon indicating copy to clipboard operation
v86 copied to clipboard

Takes longer to exit fullscreen on some browsers, can cause several seconds of accidental `Esc` keypresses

Open hello-smile6 opened this issue 2 years ago • 3 comments

Since #665 was merged, v86 now uses navigator.keyboard.lock() when available to intercept more keys in fullscreen. As a side effect, this causes exiting fullscreen to take longer on supported browsers, resulting in several seconds of the Esc key being pressed. Even one accidental Esc keypress can be destructive, but bash seems to give tab completions when the Esc key is pressed. The attached GIF demonstrates this. In the scenario shown, the main side-effect is repetitive tab-completions for the current directory (Because ./ is entered before entering fullscreen), but this could cause a v86 guest to be unusable for several minutes while listing every executable file in $PATH, as anyone who has accidentally hit tab twice in a row using the Arch Linux profile has likely noticed.

Some ideas for fixing this

  • Implement an alternative key to exit fullscreen (e.g. Ctrl+Alt+F, similar to QEMU)
  • Exit fullscreen immediately when Esc is pressed
  • Revert #665 😦 Screen Recording.gif

hello-smile6 avatar Jun 05 '22 02:06 hello-smile6

Is your PC not old?

jsinc-sebastian avatar Jun 07 '22 09:06 jsinc-sebastian

Is your PC not old?

Is your browser version over 20 versions behind? According to Mozilla's browser support data, Chromium-based browsers have supported the feature for several years.

hello-smile6 avatar Jun 07 '22 15:06 hello-smile6

OK

jsinc-sebastian avatar Jun 13 '22 13:06 jsinc-sebastian

It might be because it is very large GitHub Pages.

jsinc-sebastian avatar Jun 13 '22 13:06 jsinc-sebastian