Diamond shaped stores...

[every-in-austin]

If a store is given one of the new diamond shapes and the entrance is at one of the points of the diamond, the shopkeeper will refuse to move out of your way to allow you to enter (or presumably exit). Apparently it would cause him to lose contact with the control square just inside the door...

[copperwater]

I consider this not a bug with themed rooms but a latent problem with vanilla that assumed shops would always be rectangles of minimum size 3x2. Basically, the algorithm for deciding whether a room is valid to place a shop in does not account for rooms having only 1 square inside the door, and I believe these should be considered invalid.

First, I need to reproduce this in vanilla with the "Circular, small" themed room, then I will work on a vanilla patch that fixes it, and will keep this issue open until the fix is merged into xNetHack.

[copperwater]

OK - this doesn't appear with the Circular small room as I predicted. Is it instead this room (unique to xNetHack)?

    ---    
    |.|    
   --.--   
  --...--  
---.....---
|.........|
---.....---
  --...--  
   --.--   
    |.|    
    ---    

In this room, a shopkeeper is indeed unable to move out of your way. But the underlying problem is the same - if vanilla decided to add this room they'd have the same problem. The adjustment to the algorithm is a little more complicated though.

Submitted the fix as https://github.com/NetHack/NetHack/pull/888.

[every-in-austin]

That's the shape I encountered. Quite frustrating given it was the only store in the game (other than Izzy's) after +20k moves and, of course, undiggable walls...

[copperwater]

Should be fixed as of the recent vanilla merge.