xNetHack icon indicating copy to clipboard operation
xNetHack copied to clipboard

Demon gating message sequencing is backwards

Open copperwater opened this issue 1 year ago • 0 comments

When a weapon-wielding demon (such as a horned devil) is gated in, the message about it wielding its item will get printed before the message about it appearing in a cloud of brimstone.

This occurs because in msummon, makemon is called first to create the monster, possibly triggering messages about the monster wielding its weapon, and then the brimstone message is printed after all demons have been gated in.

Possible solutions:

  • Suppress the message about a monster wielding a weapon if it's being created. The problem with this solution, though, is that the player won't necessarily know that it is wielding a weapon at all until it attacks with that weapon.
  • Move the special summon message into makemon somehow rather than doing it after the fact. This seems like it would be messy, because makemon probably should not have to care about what its caller is doing.

copperwater avatar Mar 12 '23 01:03 copperwater