copona icon indicating copy to clipboard operation
copona copied to clipboard

SCSS (or alternative) default template for frontend

Open arnisjuraga opened this issue 9 years ago • 12 comments

arnisjuraga avatar Dec 23 '16 16:12 arnisjuraga

I really like this library https://github.com/kriswallsmith/assetic could implement it, it already takes care of the minification and management part of the whole asset, including providing more tools for the developer, but it's via composer, it probably will not accept.

prhost avatar Dec 23 '16 16:12 prhost

@prhost excellent idea... not only for this project! I wrote a rudimentary class for the same purpose, but assetic is simply awesome. :)

btafoya avatar Dec 23 '16 20:12 btafoya

And already supports twig if we use in the project (:

prhost avatar Dec 23 '16 21:12 prhost

It's ok to have default html themes scss source in the project, but have it built already for a users without extra compiling on-the-fly.

Css must be already compiled for the simplicity for "end users". Although, Assetic (or alternative) is something we should have for performance as configurable option.

I have not worked with Assetic, if someone has implemented, could you make pull request and we could take tests?

arnisjuraga avatar Dec 26 '16 18:12 arnisjuraga

The idea is to always give the two alternatives to the developer, implement new things, and improvements but always keep the pattern and not force the one that does not want to use (:

I can start working on this yes, I just need to get rid of some personal tasks, so I have not started to contribute: /

prhost avatar Dec 28 '16 15:12 prhost

@prhost whenever you have time.

By that time we need to choose and add just a simple theme with a .scss support, so any new developer can jump in and create new themes much easier (with knoledge of scss)

arnisjuraga avatar Dec 28 '16 17:12 arnisjuraga

The one you mentioned was beautiful and simple, what do you think?

prhost avatar Dec 28 '16 18:12 prhost

I am in negotiation with a developers, as it is a free version theme from a commercial developer.

arnisjuraga avatar Dec 28 '16 19:12 arnisjuraga

But because of SCSS requirements (many themes develeopers still do not use any css preprocessing ;'( ), we are slowly migrating OC default theme to SCSS anyway. Sooner or later - one or another - must be added as default theme.

arnisjuraga avatar Dec 28 '16 23:12 arnisjuraga

I particularly like the lesser but as a backend programmer I do not have much argument to defend it hehe, but from what I understand of preprocessing, if you throw the entire css inside the sass or the less it will work, then it will not be a requirement The copasa developer must use sass in their themes. I think it will be able to get for anything being that it is the one that creates the header.tpl and will also have less preprocessing or native sass if we use Assetic, just the developer choose the one we please.

prhost avatar Dec 29 '16 02:12 prhost

HarnishDesign allowed to use Simplica in Copona project. Unfortunately, they do not have SASS or any css extension version. So we will need to convert and create it ourselves.

I have added first commit https://github.com/copona/copona/commit/3db6ddd33713794de75f8431084062f2bea4e60a for theme. Please, feel free to improve it!

Its now as "optional" theme - I have left default theme folder for later replacement.

Please, if you change something - everything must be done in stylesheets/additional.css or add new css files. Please, do not modify stylesheets.css - it will be converted to scss.

arnisjuraga avatar Jan 03 '17 10:01 arnisjuraga

@JJKalnins please, convert it to .scss. Perfectly, with gulp support.

arnisjuraga avatar Jan 03 '17 10:01 arnisjuraga