copier icon indicating copy to clipboard operation
copier copied to clipboard

Improve instruction for multiselection variable

Open InAnYan opened this issue 10 months ago • 4 comments

Closes #2033.

The instruction was co-authored with @pawamoy.

Currently, I have two issues with this code:

  1. Instruction is too big.
  2. Is it okay to leave the instruction like this? Like a literal.

And yes, the instruction should be wrapped in parenthesis and shouldn't include a preceding space.

InAnYan avatar Mar 13 '25 13:03 InAnYan

Please could you post a screenshot of how it looks now?

yajo avatar Mar 16 '25 19:03 yajo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.13%. Comparing base (6a6db81) to head (72c393a). Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
+ Coverage   97.96%   98.13%   +0.16%     
==========================================
  Files          54       54              
  Lines        5807     5834      +27     
==========================================
+ Hits         5689     5725      +36     
+ Misses        118      109       -9     
Flag Coverage Δ
unittests 98.13% <100.00%> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 16 '25 20:03 codecov[bot]

image

Oh, it's on a new line.

Hope I won't open a holy war for every character in this instruction...

InAnYan avatar Mar 17 '25 08:03 InAnYan

Sorry for the delay. :face_with_peeking_eye: I don't mind a new line for the instructions. Just an alternative idea for the arrow keys: How about using Unicode arrow characters, i.e. "↓↑ keys" instead of "arrow keys"?

sisp avatar Apr 25 '25 07:04 sisp