copier icon indicating copy to clipboard operation
copier copied to clipboard

Make `mypy copier --strict` pass

Open bswck opened this issue 1 year ago • 3 comments

Actual Situation

mypy copier --strict fails with 68 errors in 7 files (checked 11 source files). Checked on compiled mypy 1.5.1, Python 3.8.17.

Desired Situation

mypy copier --strict passes successfully.

Proposed solution

Resolve all errors reported by mypy. A followup to #1431.

bswck avatar Nov 29 '23 16:11 bswck

I want to see autorefine in the action of semi-auto-resolving this, as soon as it's ready. I want to get your code-reviewer feedback afterwards.

bswck avatar Dec 08 '23 03:12 bswck

Hey @bswck ! Thanks for this nice project

Is it possible to propose a batch of small pull requests in order to fix specific mypy errors or would you prefer a single PR to fix all of them?

Lujeni avatar Jan 09 '24 20:01 Lujeni

Hey @bswck ! Thanks for this nice project

Is it possible to propose a batch of small pull requests in order to fix specific mypy errors or would you prefer a single PR to fix all of them?

Thanks for reaching out. If you want to fix this issue, then I guess you might make a single pull request with bulk fixes in logically separated commits, in line with the contributing guide.

If you're asking about autorefine, it will aim to organize fixes of linting and typechecking errors into groups that can be separated into small pull requests for the ease of reviewing and preserving easily bisectable, clean, logically grouped SCM history.

autorefine is a very big idea, but I am currently jobless and have no time nor money to take the effort all by myself. If you would like to help, let's get in touch.

bswck avatar Jan 09 '24 20:01 bswck

Resolved via #1527.

sisp avatar Apr 07 '24 05:04 sisp