coot
coot
We ought to split `SimArgs` into two parts: * `SimArgs` which only contains simulation level configuration, * `NodeArgs` which only contains node level configuration and then redefine ```haskell data DiffusionScript...
* [ ] All `Show` instances, should be either derived or at least look similar. * [ ] Provide a pretty printing type class) and instances for the types which...
All trace types should follow the following naming convention `Trace`. Furthermore, all traces configurable by `cardano-node` should use the same type name as the corresponding [option](https://github.com/input-output-hk/cardano-node/blob/master/cardano-node/src/Cardano/Tracing/Config.hs?plain=1#L66-L118=). This will simplify the...
See the comment [here](https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor.hs?plain=1#L603-L605): ```hs -- TODO: revisit the policy once we have local root peers in the governor. -- The intention is to give local root peers give head...
The block fetch decision logic shows up high in profile output. @dcoutts: > The overall point is that we're making fetch decisions too frequently. Each decision is probably appropriately expensive,...
Specifically this [comment](https://github.com/input-output-hk/ouroboros-network/pull/1655/commits/5aed7f25ef7d5c87c0cabd7250433fc93562ad39#diff-73bbe2eece00fbd2272701776bdac305R64) (linked in a PR which moves things around, but that's not related).