Alessandro Rodi comments

Results 83 comments of


                                            Alessandro Rodi

Rails 6 inconsistently overrides ActiveJob queue_adapter setting with TestAdapter

I'd like to leave this here, since it could help somebody else. In our standard configuration we use rspec and we run system tests with an `inline` adapter, and other...

Resource Loader gets ignored with Whitespace-Only ID in URL (e.g., "\n")

Sounds legit to me. Please open a PR 👍

Possible breaking change with handling of `nil` conditions in 3.5.0

Agree. I guess you could clasrify this by adding an explicit test for this case?

use flat concatenation instead of nesting conditions

Thanks for you PR. Could this lead to different results if the conditions are now "joined" without parenthesis?

can? should return false when there are no attributes that the current user can perform action on

Could you help me by adding a new test case? Thanks

The backdoor for testing doesn't work with follow redirects

I am facing the same issue upon upgrading to Rails7

Add 'silent' Parameter to setValue and setRatio

Thanks! Pulled in my fork too.

Add own SQL strategy

I am very happy to accept a PR for this feature 👍 I don't have much guidance to give, but I am happy to review the PR

Add delayed enqueue for workers that support it

Same problem here with Sidekiq. The job starts always before the object is saved. I can't understand if there is a reason not to put the callback in after_commit instead...

Move validation until after the block is called

I am open to recosider this with the required changes. As of now, I'll close.