Cooper Quintin
Cooper Quintin
do you have adb running? This looks like the issue we get when ADB is also running as a separate process. run `adb kill-server` and then run it again?
is there some reason we shouldn't check for an adb process and run `adb kill-server` as part of the installer?
I'm not opposed to this and would happily accept a PR for it.
were those only there to support the root shell? I think its fine to remove them. We should also update the windows documentation to remove any mentions of power shell...
LGTM!
@oopsbagel might know something here.
we should probably just have a `installer update orbic` and `installer update tplink` command that just updates and skips all the rooting steps and also doesn't upload a new config.toml...
I think we should have an update argument too though that skips all the rooting stuff which is not necessary for just an update.
I still think an --upgrade option to the installer that skips rooting and skips uploading the config file is the best solution here
@simonft FYI