node-pool icon indicating copy to clipboard operation
node-pool copied to clipboard

Published 20 hours ago • verified publisher icon coopernurse

Attempt to fix defaultEvictor.

Open scream314 opened this issue 6 years ago • 5 comments

If pooledResource is not a Resource (but an Error), it won't have lastIdleTime thus all ifs are returning false meaning the Resource (which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in a ResourceRequest Timed Out error (b/c all slots are occupied by stuck Resources). As a solution, idleTime is checked, and if it is falsy, the Resource gets evicted.

Signed-off-by: Daniel Schopper [email protected]

scream314 avatar Feb 08 '19 14:02 scream314

Please someone shed some light how to interpret the eslint errors in the Travis build log, I cannot figure out, what the problem is.

scream314 avatar Feb 10 '19 21:02 scream314

npm run lint or yarn run lint should fix up the formatting errors which travis is complaining about.

sandfox avatar Feb 19 '19 01:02 sandfox

This is definitely not good as it is, the added JSON.stringify produces a TypeError: Converting circular structure to JSON. Currently I am testing it with util.inspect instead.

scream314 avatar Apr 30 '19 13:04 scream314

I have reported ResourceRequest Timed Out here. I would like to ask what causes” pooledResource is not a Resource (but an Error)“ @scream314

wadeDra avatar Aug 13 '19 09:08 wadeDra

Sorry, I cannot work on this anymore. Maybe @steveetm?

scream314 avatar Nov 07 '19 23:11 scream314