barrister icon indicating copy to clipboard operation
barrister copied to clipboard

(Limited) support for Python 3.x

Open pierluca opened this issue 8 years ago • 6 comments

As part of a recent development, we have extended Python 3 support to include runtime tests. Python 2.x is still needed for IDL parsing. Would you be interested in merging this back into the main branch?

pierluca avatar Jan 20 '17 16:01 pierluca

Very cool. Thanks for the contribution.

My main question at this point is testing: I'm not sure how many folks are actively using barrister in the world (I am) but it would probably be good to have a few other folks run these changes on their projects to see if we find any regressions.

coopernurse avatar Jan 20 '17 17:01 coopernurse

Just out of curiosity, in what kind of settings has this library been run? Internal project? Web facing? Under heavy or light load?

pierluca avatar Jan 23 '17 10:01 pierluca

Do note however that plex is not supported in Python3. As such the requirement isn't really a runtime requirement but a development-time requirement. It may be interesting to keep it as optional (i.e. documented), but not hard coded into the requirements.txt

pierluca avatar Jan 23 '17 16:01 pierluca

Yes, in hindsight plex was a poor choice. It appears to be abandoned, and it doesn't install cleanly with pip unless --pre is used.

It probably wouldn't be hard to rewrite the parser with another library - perhaps a PEG parser like: https://github.com/erikrose/parsimonious

That project is active and supports python 2 and 3.

coopernurse avatar Jan 24 '17 15:01 coopernurse

To respond to your question about usage. I've been using it on a project for the last 3 years. The Java and JS barrister bindings are used (python is only used for IDL translation during builds).

I'm not sure about load, but I believe this system handles about 5 million JSON-RPC requests per day.

coopernurse avatar Jan 24 '17 15:01 coopernurse

Thanks for the info. It's much appreciated.

pierluca avatar Jan 25 '17 17:01 pierluca