Cooper Lees

Results 280 comments of Cooper Lees

Sorry I never responded here. I don't totally understand what bugbear should do here. We're an AST parsing linter, so if someone can use the AST to be smarter here...

Yeah, that is “technically pointless”, I guess. Thanks for stating the check has also helped. It seems lots of people have loved this check (myself included). I think this will...

I'd like another maintainer to comment, but if this was disabled by default I'd accept the PR as we've all done this.

Hi, thanks for the suggestion. I personally can't visualize in my head how we'd achieve that logic. If you could get a POC PR up we could consider that. That...

**B006** is there to protect you from the mutable default (in this case a dict '{}') from being initialized at your codes first pass and then at some stage mutated....

*(Context: I use mypy / pyre + type annotations a lot, I've never used `MutableMapping / Mapping` types tho)* Few questions from this: 1) So what benefit does setting the...

Sorry I never replied here, but if a PR is done, documentation is added and unittests are added I'm inclined to accept this. Just torn if we want this on...

I agree this seems a false positive, but it's very creative class instance iteration here. It's also a class variable, so all instances would modify the same value. Dangerous stuff....

Hi there, I'm going to be honest, this seems a pretty rare use case here ... but if it breaks nothing else and we give a good reason as to...

Let's refer to "module level" as Global scope. In regards to #57, and this, I potentially agree with you. I would like another maintainers approval before I'll state we'll accept...