Kevin C
Kevin C
Thank you for this work @Polarisation! The code looks great, I'll just need to find some time to test before officially merging. It may be a few weeks, but I...
Update: Rebased on latest `main` with dependency upgrades; works great on Android! Now to spend a few more hours setting up xcode... I should have this ready to merge tomorrow.
Facebook's support for upgrading RN modules is truly despicable... I'll need to start a new module from scratch and re-apply this library's code on top of it. **For anyone wanting...
Thanks for the report @iRoachie. I'm guessing this would be a simple fix by setting some sort of max width on iOS. Happy to accept PRs!
I didn't personally write the iOS implementation but I'm guessing one or both of these lines are what determines the width: - https://github.com/cooperka/react-native-snackbar/blob/master@{2018-08-11}/ios/RNSnackBarView.m#L144 - https://github.com/cooperka/react-native-snackbar/blob/master@{2018-08-11}/ios/RNSnackBarView.m#L72 You might need to dig...
thanks @TimCatana, sure I would accept a change like that for iOS!
This feature sounds similar in nature to https://github.com/cooperka/react-native-snackbar/issues/11; easy to do with plain JS, but hard to do natively. I would love to re-write this library to be completely JS...
Both could be supported at once -- it's not either/or :slightly_smiling_face: There are advantages to each.
I edited the issue description to suggest a generic solution. This is a quite popular request! I would happily merge a PR that does this well.
hi @pe-johndpope, in order to use your snackbar fork you'll need to compile and commit the `lib` directory of this library. you can do that by editing `.gitignore`, running `yarn...