coopcycle-web icon indicating copy to clipboard operation
coopcycle-web copied to clipboard

Incident V1

Open r0xsh opened this issue 11 months ago • 3 comments

https://github.com/coopcycle/coopcycle/issues/9 https://github.com/coopcycle/coopcycle-web/issues/3950

r0xsh avatar Mar 01 '24 14:03 r0xsh

Remember we cant push this until incidents dont count as "cancelled" in stripe and have that whole workflow mapped out with the "incident with delivery" and "incident with critical error" stuff Or we will accidentally not charge orders

Paul-Eraman-CoopCycle avatar Mar 07 '24 17:03 Paul-Eraman-CoopCycle

Why use *.jsx extension when everything has the *.js extension?

I prefer using .jsx file to explicitly tell when a file is a react component. This is helpful when searching in the codebase. I can rename them in .js if you prefer

r0xsh avatar Apr 25 '24 12:04 r0xsh

One more thing: did you test it with the released mobile app version? What will happen if somebody try to mark task as failed?

vladimir-8 avatar Apr 26 '24 00:04 vladimir-8

One more thing: did you test it with the released mobile app version? What will happen if somebody try to mark task as failed?

The old "mark as failed" behavior hasn't changed. I'm waiting for user feedback before making any changes to this part. Since incidents add a new step in the validation lifecycle that the rider doesn't have access to, I expect feedback from cooperatives doing "on the fly" dispatches asking me not to deactivate the ability for a rider to mark a task as failed. In the long term, I believe there will be an option to enable or disable incidents on the instance. Incidents are primarily there to manage billing and administrative issues, not logistical business problems. Cooperatives using CoopCycle solely for its logistical aspect will find incidents getting in their way.

r0xsh avatar Apr 29 '24 08:04 r0xsh