coopcycle-web icon indicating copy to clipboard operation
coopcycle-web copied to clipboard

A previously assigned tour is filtered out when you filter out the courier it was previously assigned

Open Atala opened this issue 1 year ago • 1 comments

Reported by corinne on enrouelivr instance

assign a tournée to a coursier, unassign it, filter out the coursier. The tournée is also filtered out.

Atala avatar Feb 26 '24 08:02 Atala

I think it has been fixed by the last refactoring on task.tour_id

let s see if someone can reproduce it

Atala avatar Mar 18 '24 08:03 Atala

almost fixed, the tour is now visible but the tasks in it arent. so its not uncollapsable

Image

Paul-Eraman-CoopCycle avatar Mar 29 '24 09:03 Paul-Eraman-CoopCycle

it is the intended behaviour of the couriers filter

when the filter is set, unassigned tasks are not visible

this filter = show this courier's tasks

Atala avatar Mar 29 '24 12:03 Atala

but the route is no longer assigned to the messenger, so nor are the tasks?

Paul-Eraman-CoopCycle avatar Mar 29 '24 12:03 Paul-Eraman-CoopCycle

yes the tasks are not assigned anymore but the "courier" filter hides also unassigned tasks

Atala avatar Apr 02 '24 06:04 Atala

i dont understand

in the gif I have tasks that are no longer assigned to a messenger. I filter OUT that one messenger. the only thing that should happen is that i no longer see tasks assigned to that messenger. Instead, tasks disappear. im not trying to filter out unassigned tasks in the video, that would be a different button

should we do a video chat about it?

Paul-Eraman-CoopCycle avatar Apr 02 '24 09:04 Paul-Eraman-CoopCycle

yes it is shitty behavior but it was implemented like this, unassigned tasks are filtered out

in the filters we should have a ON/OFF for unassigned tasks I agree, I already discussed that on slack actually

let s create a new issue ?

Atala avatar Apr 02 '24 11:04 Atala

yeah that works. can you create it? you seem to understand the problem better

Paul-Eraman-CoopCycle avatar Apr 02 '24 11:04 Paul-Eraman-CoopCycle

OK

Atala avatar Apr 02 '24 14:04 Atala