Divya Darshana
Divya Darshana
Hi @meher, as there hasn’t been any recent activity on this PR, we’ll go ahead and close it for now. I’d like to take some time to step back and...
@yashisrani, Self Assigning since this needs to be fixed at priority. Feel free to check out other issues. Let me know if you need help.
As far as I know, we do not register failiure count yet in Google PubSub ... Either we give total count/success count. Yes the grafana dashboard query might be wrong.
I’d also love to see this implemented. Since GoFr wraps responses within a data field, marshalling and unmarshalling often lead to errors (something I’ve personally encountered quite a few times)....
> @Umang01-hash ,The test file still uses the old SurrealDB API, so it won’t work with v1.0.0. Mock types like NewMockConnection, Send(), QueryResult, and QueryResponse no longer exist, and v1.0.0...
Thanks, @Thomas-Matheus ! We’ll definitely include this in our roadmap and will update you once the feature is approved and implemented.
Sure Assigning it to you. However I would need other maintainers @aryanmehrotra & @Umang01-hash, opinion on your implementation design.
You can start working on it. Please ensure you implement an optional parameter design pattern to avoid this from becoming a breaking change. Tag me here ! if you have...
@goginenibhavani2000, Please raise the PR. It is easier to compare the changes and suggest changes through that. The review process will get much more faster. Thank you !
@aryanmehrotra , In case of PubSub ...Pubsub connections are retried. Hence we can't fail fast. A more generalised solution needs to be proposed.