coolify icon indicating copy to clipboard operation
coolify copied to clipboard

fix: allow multi-server deployments with volume mounts

Open AyushCoder9 opened this issue 1 month ago • 3 comments

Description

Fixes #7384

Previously, the UI prevented adding multiple servers to an application if any "persistent storage" was configured. This blanket restriction incorrectly blocked Volume Mounts (Docker Volumes), which are valid for multi-server deployments (creating independent volumes on each server).

This PR refines the restriction to only block File Mounts (Bind Mounts), which require specific host paths to exist and are the intended target of this limitation.

Changes

  • Modified resources/views/livewire/project/shared/destination.blade.php to check $resource->fileStorages() instead of $resource->persistentStorages().
  • Updated the warning message to specifically mention "file mounts" instead of "persistent storage volumes".

Verification

  • Created an application with a Volume Mount -> "Add another server" is now visible.
  • Created an application with a File Mount -> "Add another server" is correctly hidden with a warning.

AyushCoder9 avatar Nov 28 '25 20:11 AyushCoder9

duplicate of https://github.com/coollabsio/coolify/pull/6214, but whatever works to fixing this :shrug:

jonathan-reisdorf avatar Nov 30 '25 07:11 jonathan-reisdorf

duplicate of #6214, but whatever works to fixing this 🤷

@jonathan-reisdorf are you merging this pr ?

AyushCoder9 avatar Nov 30 '25 11:11 AyushCoder9

@AyushCoder9 he's not a maintainer so he can't merge it. Only Peak and Andras can. They are however currently more busy with bugfixes and Coolify v5 though. The dev team has been in general unsure on how to handle volume mounts on multi-server deployments, so this might not get merged after all. See the conversation on the issue.

Cinzya avatar Nov 30 '25 14:11 Cinzya