coollabsio
[Bug]: Redeploying / Stopping no longer wait for the container to stop gracefully
Error Message and Logs
No error, the deploy logs run sudo docker rm -f [appName] without running stop before.
If I try locally with an old version like v4.0.0-beta.341 it works and I can see a docker stop --time=30 tcsg08sssog8ko48s80gso8s-170315609712
With the latest version 343 this line is no longer here.
Steps to Reproduce
- Use any app image, like
nginx:latest - Start the app, wait for it to be running
- Click on redeploy (or restart)
- The container was removed using
rmand no sign ofstop
Example Repository URL
No response
Coolify Version
v4.0.0-beta.343
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Ubuntu 24.04.1 LTS
Additional Information
In my case I've upgraded because the new version should have updated the stop timeout from 30s to 300s (I'd hope for more / configurable but 300s is great).
But now the app is directly removed without any wait time 😭
I can not give you an ETA but I will work on this soon. Dev note:
- [x] The same thing happens with the proxy
- [x] Container stopping
- [x] Container redeploy
- [ ] ...??
I am looking forward for a fix on this, as it is very important for our deployments.
Same! @peaklabs-dev If you can point where to look in the codebase I can try to fix it!
This is actually a pretty bad regression, services do not get a chance to shutdown gracefully - is there a plan to fix this any time soon?
A fix for this issue has been implemented and will be available in the next release. Thanks for your patience.
-> Note that the deploy log is a bit messy and shows things that probably should not be shown, we will improve this in the future, but in the background it now uses graceful shutdown.