coolify
coolify copied to clipboard
coollabsio
[Bug]: Penpot SERVICE_FQDN_FRONTEND environmental variable has a trailing slash
Description
With the Penpot service install, it adds a trailing slash to the SERVICE_FQDN_FRONTEND and technically, that is a url, not FQDN.I see this pattern a lot with services; the variables are stated as an "FQDN," but an FQDN is simply a host and address, like "example.com" or "sub.example.com," not the https:// prefix, nor a trailing /.
Minimal Reproduction (if possible, example repository)
Just do a one click install of Penpot
Exception or Error
The issue is that for the emails penpot sends, it uses the FQDN to construct it's callback urls and it adds it's own trailing slash, as it expects a FQDN. The result is that we end up with not found pages, instead of getting the correct callback.
This is the sort of url that comes out, note the two forward slashes after .com//
https://penpot.mydomain.com//#/auth/recovery?token=(redacted)
Version
297
https://twenty.mywebsite.com//graphql also broke my twenty crm, which is live and being used
Just noticed this today SERVICE_URL_APPWRITE is expected to generate something like appwrite-vgsco4o.example.com instead it generates with trailing slash appwrite-vgsco4o.example.com/
Yes, FQDN and URL are mixed up in some places (I will fix this in the near future). The trailing slash problem was fixed in one of the latest updates, so this is no longer an issue.
