coolify icon indicating copy to clipboard operation
coolify copied to clipboard

[Bug]: COOLIFY_FQDN and COOLIFY_URL mixed up

Open scflode opened this issue 1 year ago • 1 comments

Description

It looks like that these two predefined variables are meant to be the other way around:

SOURCE_COMMIT=f4da7f19ea6bc9d014fe57763fa9c55a270e750e
COOLIFY_FQDN=http://ag7r8oo.127.0.0.1.sslip.io
COOLIFY_URL=ag7r8oo.127.0.0.1.sslip.io
COOLIFY_BRANCH=main

The FQDN I expect to not have the transport protocol prepended.

Minimal Reproduction (if possible, example repository)

This happens with any custom deployments as far as I can tell.

Exception or Error

No response

Version

v4.0.0-beta.294

scflode avatar Jun 11 '24 06:06 scflode

Edit: This will be very hard to fix without breaking a lot of stuff (so we will leave it this way for now)

Steps to fix:

  • [ ] Switch FQDM to be actually just the domain like so: domain.com
  • [ ] Switch URL to be the URL with the protocol like so: https://domain.com/ -> Currently it is the other way around, which is quite confusing. A list of things that need to be fixed:
  • [ ] Auto-generated magic: https://coolify.io/docs/knowledge-base/add-a-service -> Switch URL and FQDN
  • [ ] Compose files for service need to be adjusted (autogenrate logic)
  • [ ] UI setting of the Domain needs to change form env variabel FQDN to URL
  • [ ] Predefined environment variables -> https://coolify.io/docs/knowledge-base/environment-variables#coolify-fqdn -> Here also FQDN needs to be switch with URLs --> URLs gives back all URLs with HTTPs or HTTP with the protocol and the FQDN only the domain with the TLD (eg. .com, .net, .io...)

peaklabs-dev avatar Jun 28 '24 09:06 peaklabs-dev

~~I do not want to switch them up (and cause breaking changes), so I will introduce 2 new envs: COOLIFY_DOMAIN_URL and COOLIFY_DOMAIN_FQDN.~~

~~Example:~~ image

Edit: Ok, thanks to @peaklabs-dev's suggestion during live-stream, I decided to fix this in a different way. For newly created applications, COOLIFY_URL and COOLIFY_FQDN will be swapped. For already existing applications, it will be used as-is.

andrasbacsai avatar Aug 28 '24 16:08 andrasbacsai