coolify icon indicating copy to clipboard operation
coolify copied to clipboard

[Bug]: GitLab source without `.git` is missing a redirection

Open yannicka opened this issue 1 year ago • 0 comments

Description

When you put in a GitLab source, there is a redirection that creates a deployment error.

With https://gitlab.com/yannicka/yannicka.fr-v2 as source:

[2024-Apr-27 10:20:57.759443] Starting deployment of https://gitlab.com/yannicka/yannicka.fr-v2:master to localhost.
[2024-Apr-27 10:20:58.037722] Preparing container with helper image: ghcr.io/coollabsio/coolify-helper:latest.
[2024-Apr-27 10:20:58.194688]

[COMMAND] docker rm -f y4oc00k
[OUTPUT]
Error response from daemon: No such container: y4oc00k

[2024-Apr-27 10:20:58.571324]

[COMMAND] docker run -d --network coolify --name y4oc00k --rm -v /var/run/docker.sock:/var/run/docker.sock ghcr.io/coollabsio/coolify-helper:latest
[OUTPUT]
bf04766a787356b5635ffaba010c6db3f95bbd479f2bed792336844478b5ceda

[2024-Apr-27 10:21:00.286442]

[COMMAND] docker exec y4oc00k bash -c 'GIT_SSH_COMMAND="ssh -o ConnectTimeout=30 -p 22 -o Port=22 -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null" git ls-remote https://gitlab.com/yannicka/yannicka.fr-v2 master'
[OUTPUT]
warning: redirecting to https://gitlab.com/yannicka/yannicka.fr-v2.git/
[2024-Apr-27 10:21:00.469916]

[COMMAND] docker exec y4oc00k bash -c 'GIT_SSH_COMMAND="ssh -o ConnectTimeout=30 -p 22 -o Port=22 -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null" git ls-remote https://gitlab.com/yannicka/yannicka.fr-v2 master'
[OUTPUT]
c553fec642038b7587fd6a83dcedaabb6f544d59	refs/heads/master

[2024-Apr-27 10:21:00.484082] Setting base directory to /artifacts/y4oc00k.
[2024-Apr-27 10:21:00.954317] Oops something is not okay, are you okay? 😢

[2024-Apr-27 10:21:00.965830] Deployment failed. Removing the new version of your application.

With https://gitlab.com/yannicka/yannicka.fr-v2.git/, it works like GitHub (I've another issue, #2083, but it's not related).

It would be nice if the link without .git automatically redirected to the correct link.

Minimal Reproduction

Put https://gitlab.com/yannicka/yannicka.fr-v2 as source when you creates a ressource.

Version

v4.0.0-beta.269

yannicka avatar Apr 27 '24 10:04 yannicka