coolify icon indicating copy to clipboard operation
coolify copied to clipboard

[Bug]: Login screen one time password/recovery code fields break password manager

Open svenissimo opened this issue 2 years ago • 4 comments

Description

When using a password manager such as 1password, logging on the user and password fields work as expected.

At the onetime password / recovery code screen using a password manager it incorrectly populates both fields with 3 characters instead of the auth code with 6.

Expected: The 1 time code should be populated in the correct field. All charactors.

Workaround You can simply copy and paste the 3 digits from recovery code into the end of 1TP

Documentation 1password provides docs on approriate approached of marking autocomplete="one-time-code" https://developer.1password.com/docs/web/compatible-website-design/ and the html and the html spec. https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill

If not already, removing hints from recovery code may help or disabled until someone clicks use recovery codes etc..

Priority Low - There is a work around and login is infrequent.

thanks

Minimal Reproduction (if possible, example repository)

  1. Enable OTP
  2. log on
  3. At the OPT / Recovery code screen use password manager

Exception or Error

No response

Version

4.0.0-beta.248

svenissimo avatar Mar 29 '24 07:03 svenissimo

I coincidentally stumbled upon this issue and was surprised, as 1password correctly auto-completes OTPs on my instance. This seems to be fixed with the changes done in v4.0.0-beta.249 and 1pw now correctly fills in the whole OTP into the One-time code input field.

PatrickRoethlisberger avatar Apr 05 '24 15:04 PatrickRoethlisberger

yes it now appears to have a different approach.. I was leaving it open for the maintainer.. assume they had seen and resolved

svenissimo avatar Apr 07 '24 18:04 svenissimo

yes it now appears to have a different approach.. I was leaving it open for the maintainer.. assume they had seen and resolved

I have made a few modifications, and it looks like it is resolved now (it works for me as well with a different password manager).

Can you please confirm if it works after updating to the latest version?

andrasbacsai avatar Apr 08 '24 07:04 andrasbacsai

@andrasbacsai yes. Can confirm looks good. Thanks!

svenissimo avatar Apr 08 '24 11:04 svenissimo