klip icon indicating copy to clipboard operation
klip copied to clipboard

Implement `BaseKindle` as an **abstract** class

Open coolharsh55 opened this issue 10 years ago • 11 comments

The BaseKindle class is used to instantiate other device classes but is not useful by itself. Parser code checks if an object is an instance of the base class in some places, so the base class should be an abstract base class in OOP terms.

coolharsh55 avatar Oct 20 '15 21:10 coolharsh55

hey there.

I am not using a kindle anymore, so this project is somewhat obsolete for me. If you want to maintain it, I would be happy to give you the repository and the owner access.

+1 on the issue btw. :)

emre avatar Oct 21 '15 06:10 emre

Thanks, that would be grand. I am an active kindle user, and was looking for a python library to parse annotations. I wrote kindle-annotations for that, and then found out about klip.

I'd be happy to develop this library further, and bring the pypi packages up to date as well.

coolharsh55 avatar Oct 21 '15 15:10 coolharsh55

cool! I am transferring the repo to you. for pypi access, can you give me an email?

emre avatar Oct 22 '15 06:10 emre

can't transfer it since you have a repository named klip. if you remove, I will make sure it's transferred to your domain on github.

emre avatar Oct 22 '15 06:10 emre

@emre my email address is me at harshp dot com. I have deleted my fork of clip, so the transfer should be possible now.

coolharsh55 avatar Oct 22 '15 11:10 coolharsh55

transferred. and It seems I need your username on pypi to add you as owner - not email. :)

emre avatar Oct 22 '15 11:10 emre

@emre should be coolharsh55

coolharsh55 avatar Oct 22 '15 11:10 coolharsh55

all set.

  • added on pypi.
  • sent a transfer request for this repository. check your email connected to the github.

:+1:

emre avatar Oct 22 '15 12:10 emre

Thanks :) The pypi package transfer is successful. The github repo hasn't been transferred. Haven't received an email either. Should we wait?

coolharsh55 avatar Oct 22 '15 12:10 coolharsh55

Update: As you can see, the transfer is complete!

coolharsh55 avatar Oct 22 '15 12:10 coolharsh55

:+1:

emre avatar Oct 22 '15 12:10 emre