AJ ONeal

Results 429 comments of AJ ONeal

You were exactly right about that scope option. Now `allow` and `deny` have the proper action. When I click deny and then go back to click login again (from the...

It seems like the best thing to do would probably be to change `strategies` into a hash or an array of hashes ``` req.authenticate([{ "name": "facebook", "scope": ["email", "birthday"] }],...

To help me understand a little better. The new call would look like this? ``` req.authenticate(['facebook'], { scopes: ["email", "birthday"] }, onAuthenticated); ```

Bump. Did I understand you correctly or not? From what I saw in the code I think that it would be less work and cleaner to change the signature to...

Still failing on Windows. From the CI tests: ``` --- FAIL: TestLoadQuotedEnv (0.00s) 7 godotenv_test.go:38: Mismatch for key 'OPTION_K': expected '"line one\nthis is \\'quoted\\'\none more line"' got '"line one\r\nthis is...

@joho I know you're busy. Is there any sort of help that someone else could give to get this moving forward?

You could of course add a little love to it like this: ``` javascript if (process.versions && process.versions.node) { console.warn("[path installed via npm]: YOU'RE DOING IT WRONG! See https://github.com/jinder/path/issues/6"); }...

Actually... you could do what I do with [unibabel](https://github.com/coolaj86/unibabel-js)'s [package.json](https://github.com/coolaj86/unibabel-js/blob/master/package.json) I set `"main": "node.js"` and `"browser": "unibabel.js"`. You can then have the `node.js` output "you're using this module incorrectly..." Also,...

attach a message using [`npm deprecate`](https://docs.npmjs.com/cli/deprecate)? ``` npm deprecate path@"< 99" "This is for the BROWSER. Do NOT use it for NODE. See https://github.com/jinder/path/issues/6" ```

@chmin Awesome. In the meantime would you mind doing a manual upload of the bare Windows binary for 0.7.5 using the 0.7.6+ naming convention? That way I can go ahead...