docker-misp icon indicating copy to clipboard operation
docker-misp copied to clipboard

Published 20 hours ago • verified publisher icon coolacid

Add Environment Variable concept

Open 8ear opened this issue 4 years ago • 5 comments

Hi, as mentioned in #19 and in #88. The following is my proposal for an environment variable concept.

Please review and add feedback how you find it?

Kind regards

8ear avatar Feb 28 '21 18:02 8ear

Having a more variable spoken approach sound good. Only naming convention will break my current PR https://github.com/coolacid/docker-misp/pull/88 This one is especially designed to allow setting MISP variables via ENVs in a dynamic way. Not to be put in a strict vars.sh file. There are hundreds of settings that can be modified using cake CLI.

If we can integrate both PRs its fine with me.

And another thing to point out is that changing all existing environment variable names will break all existing setups of this project. So this might actually end up in a lot of work.

garrit-schroeder avatar Mar 03 '21 10:03 garrit-schroeder

Having a more variable spoken approach sound good. Only naming convention will break my current PR #88 This one is especially designed to allow setting MISP variables via ENVs in a dynamic way. Not to be put in a strict vars.sh file. There are hundreds of settings that can be modified using cake CLI.

That was not my intention of the default_vars.sh. The intention of that file is to define default values for variables which should be always set. Nothing more.

If we can integrate both PRs its fine with me.

Yeah I think this will be a great idea. But I am not so aware with you code. So can you support me here so that we can get both PR together? I added already comment on your PR but I am unsure if this will work.

And another thing to point out is that changing all existing environment variable names will break all existing setups of this project. So this might actually end up in a lot of work.

What we can do is to support the existing ENV vars a few versions long and map it internally in the entrypoint to the new one. So I think this should not be a big problem.

8ear avatar Mar 03 '21 16:03 8ear

It looks that the cake settings does not work. I need to check why this does not be recognized.

8ear avatar Mar 28 '21 19:03 8ear

It looks that the cake settings does not work. I need to check why this does not be recognized.

I fixed it.

8ear avatar Mar 30 '21 16:03 8ear

I'm going to need to look at this a few more times. Also, will need a rebase - and check Codacy issues.

coolacid avatar Apr 19 '21 14:04 coolacid