react-player icon indicating copy to clipboard operation
react-player copied to clipboard

`canEnablePIP` is not defined when using `'react-player/file'`

Open alessandroliveri opened this issue 1 year ago • 0 comments

Current Behavior

FilePlayer.canEnablePIP returns always false even if the feature is supported because it seems to be undefined here https://github.com/cookpete/react-player/blob/9d582014ebd7d62a0f408f4959489a49c04e4a66/src/ReactPlayer.js#L41

Expected Behavior

FilePlayer.canEnablePIP returns true when it should

Steps to Reproduce

  1. use import FilePlayer from 'react-player/file';
  2. call FilePlayer.canEnablePIP

Environment

  • Browser: Chrome, Safari
  • Operating system: Mac OS 14.1

Other Information

using ReactPlayer.canEnablePIP by importing it from react-player works as expected

alessandroliveri avatar Nov 20 '23 11:11 alessandroliveri