react-player icon indicating copy to clipboard operation
react-player copied to clipboard

Vimeo videos warning: Allow attribute will take precedence over 'allowfullscreen'.

Open edgard-tanchenec2 opened this issue 2 years ago • 1 comments

Current Behavior

Using the lib version 2.10.1 with React 17 or React 18, for Vimeo videos I get the following warning in the browser console: Allow attribute will take precedence over 'allowfullscreen'.

This is the code

<ReactPlayer
        url="https://vimeo.com/70591644"
        controls={true}
        height={"100%"}
        light={false}
        loop={false}
        muted={false}
        pip={false}
        playbackRate={1}
        playing={false}
        playsinline={false}
        progressInterval={1000}
        style={{}}
        volume={null}
        width={"100%"}
        wrapper={"div"}
      />

Expected Behavior

No warning

Environment

  • URL attempting to play: any Vimeo video
  • Browser: latest Chrome
  • react 18, 17
  • react-player: 2.10.1
  • Codesandbox example: https://codesandbox.io/s/flamboyant-rubin-5jiqn2?file=/src/App.js:123-515 you may see a warning in the browser console

Other Information

This is the relevant: https://github.com/cookpete/react-player/issues/1444

edgard-tanchenec2 avatar May 16 '22 13:05 edgard-tanchenec2

Looks like 9924137ba7891df4b8dea71be9ce4b70810474bb wasn’t enough and we need to use the "existing player" embed: https://github.com/vimeo/player.js/issues/687#issuecomment-781483072

cookpete avatar May 16 '22 21:05 cookpete

ReactPlayer uses the Vimeo sdk to get the iframe and it seems to be resolved.

luwes avatar Oct 11 '23 16:10 luwes