Pete Cook

Results 78 comments of Pete Cook

@philosofonusus Please re-open with more detail if this is still an issue.

These workarounds look good. It’s also possible this is fixed in `[email protected]` and `[email protected]`

> Rendering the component on the client side only isn't a solution @mrgnou I’m happy to reopen this for visibility (although there is quite a backlog of issues now and...

Does [custom templates](https://github.com/cookpete/auto-changelog#custom-templates) not solve this?

Ah good spot! I should add an option to not remove indentation from templates. Or maybe just never remove indentation for custom templates? Actually, that gets tricky when you have...

Similar discussion here: https://github.com/cookpete/react-player/issues/1079#issuecomment-751851186 It has been a while (years) since I looked at the `isPlaying` logic in any detail. I remember seeing lots of bugs without it, and I...

What type of URL are you trying to play? That’s kind of important. Every third party player that ReactPlayer loads will have its own autoplay nuances, and always be at...

I think for the time being it’s fine to merge these extra players, with maybe some emphasis in the `Usage` part of the readme to make it clear that importing...

Hey @jessp01 I see two options: - Add something to the readme (or somewhere appropriate) to explain that you will need to include `asciinema-player.css` somewhere in your bundle for the...

This is because we are using `memoize-one` here, which (incorrectly) assumes that the config will only ever change when the URL changes: https://github.com/cookpete/react-player/blob/53e4aede5d116c7047e5371c530e55d291ef2ad8/src/ReactPlayer.js#L121-L129 I'm open to ideas. Maybe a `config.key`...