cookietemple icon indicating copy to clipboard operation
cookietemple copied to clipboard

Question: Why was darglint removed in the python cli template?

Open picciama opened this issue 2 years ago • 2 comments

Question

In this commit: https://github.com/cookiejar/cookietemple/commit/faaff93fc0610e0e74a6f9ade98ceb9a9d383cdc darglint was removed from the pre-commit session. What is the reason behind this?

How would I need to change this - if I overwrite my noxfile, won't the change be reverted upon next time of cookietemple sync with a new version getting pushed from TEMPLATE?

I also suggest removing .darglint from the template as it isn't used anymore if not darglint is reintegrated into the pre-commit session by default.

picciama avatar Jan 20 '23 10:01 picciama

If I recall correctly darglint slowed down the pre-commit a loooot for bigger packages. Hence, I removed it.

I don't think that the sync PR would suggest to remove the retrospectively added darglint, right @Imipenem ?

Ups, we somehow forgot about the .darglint file. We'll remove it.

Zethson avatar Jan 20 '23 10:01 Zethson

Also delete darglint from the dev dependencies then: https://github.com/cookiejar/cookietemple/blob/462ccf63bef17d9fdeb3884f2e94a88ba5703e13/cookietemple/create/templates/cli/cli_python/%7B%7B%20cookiecutter.project_slug_no_hyphen%20%7D%7D/pyproject.toml#L44

picciama avatar Jan 20 '23 12:01 picciama