cookiecutter icon indicating copy to clipboard operation
cookiecutter copied to clipboard

Bugfix/jinja2 change delimiters of the template folder

Open mariovagomarzal opened this issue 2 years ago • 4 comments

Addresses https://github.com/cookiecutter/cookiecutter/issues/1736.

Based on the bugfix by @liortct in https://github.com/cookiecutter/cookiecutter/pull/1767 but using the organization name throughout the project.

mariovagomarzal avatar May 03 '23 14:05 mariovagomarzal

This changes the signature of the functions -> breaking change.

jensens avatar Jun 12 '23 12:06 jensens

As this is a breaking change, we will add it to the 3.0.0 milestone

ericof avatar Jun 13 '23 13:06 ericof

Would it be sufficient to give the environment parameter a default of None and then conditionally use its settings? For example:

def find(x, environment = None):
    left_delimiter = "{{"
    right_delimiter = "}}"
    if environment is not None:
        left_delimiter = environment.x
        right_delimiter = environment.y
    ...

Would that allow this to get merged immediately as a bugfix instead of a breaking change?

kurtmckee avatar Jun 13 '23 14:06 kurtmckee

Was this addressed with merge of #1997 ?

jensens avatar Feb 21 '24 17:02 jensens

Yes, I think we can close this pull request.

Sorry for the late response.

mariovagomarzal avatar Mar 21 '24 20:03 mariovagomarzal