cookiecutter-django icon indicating copy to clipboard operation
cookiecutter-django copied to clipboard

`--no-deps` on `docs/Dockerfile` should be removed

Open aleprovencio opened this issue 3 years ago • 0 comments

What happened?

I'm talking about this instruction below:

# create python dependency wheels
RUN pip wheel --no-cache-dir --wheel-dir /usr/src/app/wheels  \
  -r /requirements/local.txt -r /requirements/production.txt \
  && rm -rf /requirements

This --no-deps switch will make the image not consider dependencies on requirements files coded like: some-django-package[some-python-package]

As a result, user will face a ModuleNotFoundError for the docs container.

What should've happened instead?

Remove it from the docs/Dockerfile just like the other Dockerfiles on this project.

Additional details

  • Host system configuration:
    • Version of cookiecutter CLI (get it with cookiecutter --version): Cookiecutter 2.1.1 from /usr/lib/python3.10/site-packages (Python 3.10.6 (main, Aug 3 2022, 17:39:45) [GCC 12.1.1 20220730])
    • OS name and version:
      Archlinux
      
      
    • Python version, run python3 -V: Python 3.10.6
    • Docker version (if using Docker), run docker --version: Docker version 20.10.17, build 100c70180f
    • docker-compose version (if using Docker), run docker-compose --version: Docker Compose version 2.10.0
    • ...
  • Options selected and/or replay file: On Linux and MacOS: cat ${HOME}/.cookiecutter_replay/cookiecutter-django.json (Please, take care to remove sensitive information)
    # Important part is:
    "use_docker": "y",
    
Logs:
$ cookiecutter https://github.com/cookiecutter/cookiecutter-django
project_name [Project Name]: ...

aleprovencio avatar Aug 25 '22 14:08 aleprovencio