cookiecutter-django icon indicating copy to clipboard operation
cookiecutter-django copied to clipboard

set SERVERS in production settings instead of base settings

Open ghazi-git opened this issue 3 years ago • 0 comments

it is removed from local settings since having the url as 127.0.0.1:8000 triggers a CORS issue when the project runs on localhost:8000. It is kept in production settings as that allows tools that generate code samples to point to the correct domain.

Description

Checklist:

  • [ ] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • [ ] I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Based on the comments in the issue, I thought it would be good to keep SERVERS in production settings so the original goal of adding it is met, but also thought it might not be useful in local settings (plus adding it requires setting CORS_ALLOWED_ORIGINS=["localhost:8000"])

fixes #3593

ghazi-git avatar Feb 20 '22 20:02 ghazi-git