freecache icon indicating copy to clipboard operation
freecache copied to clipboard

fix: fix slice init length

Open cuishuang opened this issue 1 year ago • 3 comments

The intention here should be to initialize a slice with a capacity of len(staffCustomerIDs) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

cuishuang avatar Sep 26 '24 06:09 cuishuang

@coocood Hi, could you please review this PR? Thank you!

cuishuang avatar Oct 30 '25 16:10 cuishuang

The intension is initializing the length, or the test would fail.

coocood avatar Oct 31 '25 00:10 coocood

you are right here, but not right to the context of the ring buffer, when the ring buffer tries to set a segment a value, they store the length not the capacity of the object and the capacity of the object is not concerned with the implementation for several reasons, so TLDR: the capacity is ignored and the length is the actual matter attribute

Amr-Shams avatar Nov 03 '25 11:11 Amr-Shams