thumbnailator icon indicating copy to clipboard operation
thumbnailator copied to clipboard

Scale up disabled feature

Open radoslavdodek opened this issue 9 years ago • 7 comments

Hi,

I've implemented one tiny feature called "Scale Up disabled", which lets you enable/disable scaling thumbnail up in case thumbnail size is set bigger than original image. Usually I don't want to scale up a thumbnail as this creates a distortion of the image. I only want to scale it down if necessary. Please take a look on it and if you find it useful, feel free to merge it into main repository. Also feel free to contact me with any questions or requests.

Radoslav.

radoslavdodek avatar Dec 11 '15 17:12 radoslavdodek

I've just noticed that there is an Issue (#85) opened asking for similar feature as the one I've implemented.

radoslavdodek avatar Dec 11 '15 17:12 radoslavdodek

Any updates on this? Would be very cool if this PR could be merged if there are no other concerns.

nioe avatar Apr 06 '16 13:04 nioe

This PR contains a lot of white spaces changes. A PR should generally address only a single concern; any code re-formatting should be done separately.

mwiehl avatar Apr 13 '16 06:04 mwiehl

I'm in need of this feature, but the whitespace changes are unnecessary.

I'll try to extract only the real changes.

thiago-negri avatar Jun 08 '16 14:06 thiago-negri

I've created PR #94 for this and used a positive property "scaleUp" instead of a negative one "scaleUpDisabled".

thiago-negri avatar Jun 08 '16 16:06 thiago-negri

Thanks thiago-negri, as I didn't have time to remove unnecessary white spaces, your PR will help the others to use this feature.

radoslavdodek avatar Jun 09 '16 06:06 radoslavdodek

for a work-around see https://github.com/coobird/thumbnailator/pull/94#issuecomment-366489245

nqzero avatar Feb 18 '18 03:02 nqzero

Thank you for your interest! Pull requests are currently not being accepted.

coobird avatar Nov 21 '22 16:11 coobird