apollo-cache-hermes icon indicating copy to clipboard operation
apollo-cache-hermes copied to clipboard
verified publisher icon convoyinc

RangeError: Maximum call stack size exceeded with a slightly complex query

Open capaj opened this issue 6 years ago • 0 comments

here: https://github.com/apollographql/apollo-client/blob/451482ff85d93e1738df31007f3c2a7f0fbe8cff/packages/apollo-client/src/core/ObservableQuery.ts#L262

there is a call which tries to compare two objects. The problem I get when I switch to hermes from apollo-cache-inmemory is that these objects are circular. Proof: image

IMHO the fix should either be to make the objects not be circular or the isEqual: https://github.com/apollographql/apollo-client/blob/451482ff85d93e1738df31007f3c2a7f0fbe8cff/packages/apollo-utilities/src/util/isEqual.ts#L4 needs to be able to handle circular objects.

I have

    "apollo-client": "^2.6.0",
    "apollo-cache-hermes": "^0.8.9",

capaj avatar Jun 01 '19 13:06 capaj