Allow network whitelisting on the service level
I think this syntax is correct but I'd recommend some manual testing of this, just to be sure!
Codecov Report
Base: 36.19% // Head: 36.22% // Increases project coverage by +0.02% :tada:
Coverage data is based on head (
ae88e4f) compared to base (e087555). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #3581 +/- ##
==========================================
+ Coverage 36.19% 36.22% +0.02%
==========================================
Files 168 168
Lines 18413 18418 +5
==========================================
+ Hits 6665 6672 +7
+ Misses 10616 10613 -3
- Partials 1132 1133 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/manifest/service.go | 41.02% <ø> (ø) |
|
| provider/aws/template.go | 0.00% <0.00%> (ø) |
|
| pkg/logstorage/logstorage.go | 87.91% <0.00%> (+7.69%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@beastawakens if you could also create some tests to assert this new functionality we would greatly appretiate