rack icon indicating copy to clipboard operation
rack copied to clipboard

Internal DNS records based on Rack status, not app status

Open beastawakens opened this issue 3 years ago • 2 comments

beastawakens avatar Sep 22 '21 11:09 beastawakens

This covers a use case where on a Rack with mixed internal and public services, the 'local' DNS record for an app/service ([service].[app].[rack].convox) is directed at the public load balancer, so the internal services can't access it.

This change checks for the presence of an internal load balancer for the Rack and if it exists, the DNS record will now be pointed at that.

beastawakens avatar Mar 29 '22 11:03 beastawakens

Codecov Report

Merging #3467 (41fa7ae) into master (787a54a) will increase coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
+ Coverage   34.49%   34.52%   +0.02%     
==========================================
  Files         128      128              
  Lines       15566    15576      +10     
==========================================
+ Hits         5370     5377       +7     
- Misses       9279     9281       +2     
- Partials      917      918       +1     
Impacted Files Coverage Δ
provider/aws/releases.go 9.65% <0.00%> (-0.20%) :arrow_down:
pkg/logstorage/logstorage.go 87.91% <0.00%> (+7.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95b1fca...41fa7ae. Read the comment docs.

codecov[bot] avatar Mar 29 '22 11:03 codecov[bot]