convox icon indicating copy to clipboard operation
convox copied to clipboard

Feat-542: Add ssh capability for v3 rack

Open nightfury1204 opened this issue 3 years ago • 3 comments

https://github.com/convox/issues-private/issues/542

nightfury1204 avatar Sep 28 '22 17:09 nightfury1204

https://user-images.githubusercontent.com/12232198/194627934-6419ccad-5c91-4bc5-a35d-87bfad8008be.mp4

nightfury1204 avatar Oct 07 '22 18:10 nightfury1204

e2e tests: https://github.com/convox/convox/actions/runs/3206321965

nightfury1204 avatar Oct 07 '22 19:10 nightfury1204

@nightfury1204 forgot to put on the review, but please add into the documentation this new key_pair_name parameter, and document the instances keyroll and ssh commands in this section https://docs.convox.com/reference/cli/instances/

heronrs avatar Oct 11 '22 13:10 heronrs

LGTM, add the e2e tests if you can

@heronrs added the e2e test for it

nightfury1204 avatar Oct 20 '22 18:10 nightfury1204