converse.js icon indicating copy to clipboard operation
converse.js copied to clipboard

feat(register): provider autocomplete (addresses #2740)

Open Bennethxyz opened this issue 2 months ago • 2 comments

This PR now also fixes provider autocomplete in the Add Contact modal:

  • Corrects property bindings for .list and .data (were passed as strings)
  • Triggers suggestions on @ with min_chars=1
  • Merges configured registration_providers into the JID domain list

This complements the registration form autocomplete and addresses #2929 as well.

Bennethxyz avatar Oct 22 '25 12:10 Bennethxyz

Update: also fixed provider autocomplete in Add Contact modal (bindings + @ trigger) and merged registration_providers into the domain list, addressing #2929.

Bennethxyz avatar Oct 22 '25 12:10 Bennethxyz

Added accessibility improvements for the audio player (fixes #3382):

  • and
  • Keeps caption/hostname for context when not hidden

Tested with keyboard-only navigation; happy to tweak ARIA per your guidance.

Bennethxyz avatar Oct 22 '25 14:10 Bennethxyz

@Bennethxyz Please create separate PRs when you are fixing separate tickets.

For example:

Added accessibility improvements for the audio player (fixes https://github.com/conversejs/converse.js/issues/3382):

This needs to go into a different PR.

Thanks.

jcbrand avatar Dec 14 '25 07:12 jcbrand