Contact stays in "pending contacts"

[Tomo59]

Describe the bug personA sees personB in "pending contacts" even if personB accepted the request.

Then if personA deletes personB contact and adds it again, personB is correctly in "ungrouped" contacts. BUT personB now sees personA in "pending contacts".

So no matter what we do one of the 2 persons will see the other in "Pending contacts".

To Reproduce Steps to reproduce the behavior:

1. personA add a new contact personB
2. personB accepts the contact request
3. one of the person sees the other in "pending contacts"

Expected behavior Both persons should see the other contact in "ungrouped" group.

Environment (please complete the following information):

• Desktop
• Chromium Version 99.0.4844.51 (Official Build) snap (64-bit)
• Converse.js version (master branch as of March 10th 2022 : commit 47b016599ef633233092682e683d9a82a6137ec0)

Additional context I attach the log of personA's Converse where personA has personB in pending contact, personA deletes this contact and readd it, personA is OK but personB sees personA in pending contacts and then personB does the same and personA' side is broken again.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Tomo59]

Please note that the trick mentioned in https://github.com/conversejs/converse.js/issues/1185 is not working because if I add personB while he is in my "pending contacts" group, I have an error "This contact has already been added".

Maybe one way to fix the issue is to allow back to add someone already in your "pending contacts".

[jcbrand]

Thanks for the detailed bug report. I've looked at the logs, looks like Converse is sending another subscribe stanza, even after personB has accepted the subscription.

I'll try to see whether I can reproduce the issue.

Are both users using Converse? Also, the logs are from the perspective of personA, right?

[Tomo59]

Are both users using Converse?

Yes, and even the same version of Converse

Also, the logs are from the perspective of personA, right?

Yes, I edited the issue to make it clearer.